Fix missing data_consistency label in Sidekiq metrics
What does this MR do?
We recently introduced database load balancing capabilities for Sidekiq jobs. As part of this we started emitting new metrics into Prometheus to track e.g. how often replicas or the primary are being picked. We were also emitting the job's data_consistency
setting, but it was never actually written to the job hash, so it came out empty in Prometheus.
This MR fixes that.
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) - [-] I have tested this MR in all supported browsers, or it's not needed.
- [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Related to #330610 (closed)
Edited by Matthias Käppler