Make clear Redis "default_url" is not an example to be followed
What does this MR do?
This is part of gitlab-com/gl-infra/scalability#1058 and spun off from !62767 (merged).
Gitlab::Redis::{Cache,Queues,SharedState} have default URL's that get used in case there is no YAML config file. These default URL's make no sense because they are not the default Redis URL (localhost:6379); instead they are localhost:6380, localhost:6381 and localhost:6382. It is very unlikely that anybody is using them but it is hard to rule out.
As a compromise for removing these default URL's altogether, this MR refactors the Redis instance configuration code so that default_url is not part of the shared configuration logic in Gitlab::Redis::Wrapper which should hopefully prevent whoever adds Redis instances in the future (e.g. !62767 (merged)) from cargo-culting the default URL mechanism.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team