Skip to content

Fix retry-lock problem on pipeline cancel

Furkan Ayhan requested to merge 332252-cancel-retry-nil into master

What does this MR do?

Having the retries parameter nil causes an error on Gitlab::OptimisticLocking when comparing retry_attempts < max_retries. (Bug issue: #332252 (closed))

So we need to change its default value. We can make it 0, but I think it's better to have 1 to have a "secure" cancel mechanism.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Furkan Ayhan

Merge request reports