Skip to content

Improve cache sharing between cached markdown fields and mentionables

Nick Thomas requested to merge 244851-share-commit-markdown-cache into master

What does this MR do?

This change makes an item of implicit coupling between the Mentionable and CachedMarkdownField concerns. Mentionable needs to render the fields it depends on to extract references; when those fields are also cached markdown fields, it currently uses that cache to skip the render step.

For the Commit model, we couldn't share the cache because Mentionable was looking at safe_message, while CachedMarkdownField was looking at title, full_title, and description. However, the combination of the latter two is equivalent to safe_message, so we can use them instead.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Related to #244851 (closed)

Edited by Nick Thomas

Merge request reports