Skip to content

[RUN ALL RSPEC] Load Rails 5.1 configuration defaults

Heinrich Lee Yu requested to merge load-rails-5-1-defaults into master

What does this MR do?

Part of #332288 (closed)

From https://guides.rubyonrails.org/configuring.html#results-of-config-load-defaults, calling load_defaults 5.1 sets the following values:

config.assets.unknown_asset_fallback: false
config.action_view.form_with_generates_remote_forms: true

config.action_controller.per_form_csrf_tokens: true
config.action_controller.forgery_protection_origin_check: true
ActiveSupport.to_time_preserves_timezone: true
config.active_record.belongs_to_required_by_default: true
config.ssl_options: { hsts: { subdomains: true } }

Some of these we set back to the previous values because they're not compatible with our code.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu

Merge request reports