Enable Style/GlobalStdStream
What does this MR do?
STDOUT
and friends are constants which means, amongst other things, they cannot be replaced using the rspec output matchers. Instead we should use the global version of the same thing $stdout
etc.
This MR uses rubocops automatic fixup to replace all relevant violations as per https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/GlobalStdStream
I suspect the reason using STDOUT
is so common while initialising loggers is because of the stdlib docs https://ruby-doc.org/stdlib-3.0.1/libdoc/logger/rdoc/Logger.html#class-Logger-label-How+to+create+a+logger - As far as I know there's no reasoning behind this.
This MR was split from !62536 (merged) which adds a rspec filter to redirect $stdout
- this filter will work much better once STDOUT
is replaced by $stdout
as per this MR.
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team