Skip to content

Fix shared runner minutes reset on self-managed

What does this MR do?

When namespace count is lower than 100,000, the :ci_parallel_minutes_reset feature fails with a zero division error due to integer division

This affects most self-managed instances but not GitLab.com which has well over 100,000 namespaces

The fix here is done by using float division to avoid the chance of a ZeroDivisionError in such edge cases

Closes: #330068 (closed)

Screenshots (strongly suggested)

{ … 
  "error_message":"divided by 0",
  "error_class":"ZeroDivisionError",
  "error_backtrace": [
    "ee/app/workers/clear_shared_runners_minutes_worker.rb:21:in `perform'",

  ]

}

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Merge request reports