Skip to content

Helm charts index API endpoint

Mathieu Parent requested to merge sathieu/gitlab:helm_index_yaml into master

What does this MR do?

This implements: GET /api/v4/projects/<id>/packages/helm/<channel>/index.yaml, i.e. item 3.3 of #18997 (comment 530270349)

Query plan

        packages = Packages::Helm::PackageFilesFinder.new(
          @project,
          @channel,
          order_by: 'created_at',
          sort: 'desc'
        ).execute.preload_helm_file_metadata
SELECT
    "packages_package_files".*
FROM
    "packages_package_files"
    INNER JOIN "packages_packages" ON "packages_packages"."id" = "packages_package_files"."package_id"
    INNER JOIN "packages_helm_file_metadata" ON "packages_helm_file_metadata"."package_file_id" = "packages_package_files"."id"
WHERE
    "packages_packages"."project_id" = 1
    AND "packages_packages"."package_type" = 11
    AND "packages_packages"."status" = 0
    AND "packages_helm_file_metadata"."channel" = 'stable'
ORDER BY
    "packages_package_files"."id" DESC
LIMIT 1000;

Explain: https://explain.depesz.com/s/Ks09#html

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Mathieu Parent

Merge request reports