Skip to content

GitLab Next

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 43,075
    • Issues 43,075
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,376
    • Merge requests 1,376
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge requests
  • !62725

Use cluster integrations by default [RUN AS-IF-FOSS]

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Hordur Freyr Yngvason requested to merge use-cluster-integrations-by-default into master May 27, 2021
  • Overview 15
  • Commits 1
  • Pipelines 11
  • Changes 36

What does this MR do?

Changes references to Clusters::Applications::{ElasticStack,Prometheus} to the corresponding Clusters::Integrations::{ElasticStack,Prometheus} where appropriate.

For context, we are removing one-click applications from GitLab but leaving the integrations for Prometheus and Elastic Stack.

We have code in place that keeps the integration in sync with the corresponding cluster application, and have backfilled the integrations, so we can now use them as a source of truth.

This is not a breaking change (alert updates continue to work for now), but should make it a lot easier to remove the application models when the time comes.

See

  • Backfill Prometheus: !61502 (merged)
  • Backfill Elastic Stack: !61521 (merged)
  • Deprecation Epic: &4280

Screenshots (strongly suggested)

Steps taken:

  1. Added a cluster
  2. Installed prometheus and elastic stack
    • Pod logs work ✅
    • Metrics work ✅
    • Alerts work ✅
  3. Ran cluster.application_elastic_stack.delete and cluster.application_prometheus.delete
    • Pod logs work ✅
    • Metrics work ✅
    • Alerts work ✅
Pod logs Metrics Alerts
Screenshot_2021-05-28_Administrator_minimal-ruby-app_1_ Screenshot_2021-05-28_Metrics_Dashboard___production___Administrator_minimal-ruby-app_1_ Screenshot_2021-05-28_Alerts___Administrator_minimal-ruby-app

Does this MR meet the acceptance criteria?

Conformity

  • I have included a changelog entry, or it's not needed. (Does this MR need a changelog?)
  • I have added/updated documentation, or it's not needed. (Is documentation required?)
  • I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
  • I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
  • I have self-reviewed this MR per code review guidelines.
  • This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines)
  • I have followed the style guides.

Availability and Testing

  • I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.)
  • I have tested this MR in all supported browsers, or it's not needed.
  • I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Edited May 28, 2021 by Hordur Freyr Yngvason
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: use-cluster-integrations-by-default