Skip to content

Disable Sharing of Groups Outside Hierarchy PoC

Jason Goodman requested to merge group-share-lock-spike into master

What does this MR do?

Proof of concept for #217623 (closed)

Screenshots

With the feature off (default, current behavior)

The group can be shared with groups outside the group hierarchy.

In this case, the Mars group is shared with the Books group, which is outside the Solar System group hierarchy.

Screen_Recording_2021-05-26_at_6.28.26_PM

With the feature turned on

Turn the feature on

TurnOnFeature

Sharing Outside Group Hierarchy is Disabled

The group cannot be shared with groups that lie outside the Solar System group hierarchy.

Notice the Books and Animals groups, visible in the previous scenario, are not options in the group search.

The Mars group can still be shared with any groups within the Solar System hierarchy.

CannotShare

The Setting Appears for a Root Group

There

The Setting Does Not Appear for a Subgroup

NotThere

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jason Goodman

Merge request reports