Skip to content

Remove preloading of forks in projects API

Heinrich Lee Yu requested to merge 211495-remove-preloading-of-all-forks into master

What does this MR do?

Removes preloading of forks because they're not needed. This can result in a huge number of records being loaded unnecessarily.

We already compute the number of forks more efficiently in https://gitlab.com/gitlab-org/gitlab/blob/d272f91af6a9ede3e0680ce9be1e420d296ef53e/app/services/projects/batch_forks_count_service.rb#L24-30

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #211495 (closed)

Edited by Heinrich Lee Yu

Merge request reports

Loading