Skip to content

Fix failure reason for dropped builds on CI quota exhaustion

What does this MR do?

Related to https://gitlab.com/gitlab-org/gitlab/-/issues/323486 and #326709 (comment 585367787)

We drop the builds when the quota is exceeded, but we do it with the wrong failure reason because the instance_runners array is empty:

And on top of this we were dropping pipelines for public projects that are part of namespaces with used up CI minutes.

Screenshots (strongly suggested)

Before:
image

After:
image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Marius Bobin

Merge request reports