Remove excessive specificity in refactoring of left-hand panel with the flag OFF
What does this MR do?
It removes the excessive specificity for the BASE stylesheet in the process of refactoring of the left-hand panel. During the previous testing, several issues related to the added specificity of the styles even with the feature flag OFF, have been identified:
- Too high specificity for
topstyle of the panel when the performance bar and the system header are present - Too high specificity for the
svgicons in the panel
This MR addresses such things and completely removes higher specificity for the scenario with the feature flag (:sidebar_refactor) OFF by elevating the styles of contextual_sidebar_base.scss to the root level instead of keeping those prefixed with body:not(.sidebar-refactoring) by employing @at-root() function of SCSS.
At the same time, the MR preserves the higher specificity for the refactored styles to make it easier to spot issues like the one with the SVG icon above where it becomes clear that the CSS is simply not needed there as we rely on the utility classes.
Screenshots (strongly suggested)
| Before | After |
|---|---|
 |
 |
The screenshots illustrate both issues mentioned above (top of the panel and the size of the svg icon) being fixed.
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #322680 (closed)