Remove retry of docs job
What does this MR do?
With gitlab-docs!1820 (merged) merged, we can undo: !61868 (merged).
That way we can hopefully close: #331002 (closed).
Author's checklist (required)
-
Follow the Documentation Guidelines and Style Guide. - If you have Developer permissions or higher:
-
Ensure that the product tier badge is added to doc's h1
. -
Apply the documentation label, plus: - The corresponding DevOps stage and group labels, if applicable.
-
development guidelines when changing docs under
doc/development/*
,CONTRIBUTING.md
, orREADME.md
. -
development guidelines and Documentation guidelines when changing docs under
development/documentation/*
. - development guidelines and Description templates (.gitlab/*) when creating/updating issue and MR description templates.
-
Request a review from the designated Technical Writer.
-
Do not add the feature, frontend, backend, ~"bug", or database labels if you are only updating documentation. These labels will cause the MR to be added to code verification QA issues.
When applicable:
-
Update the permissions table. -
Link docs to and from the higher-level index page, plus other related docs where helpful. -
Add the product tier badge accordingly. -
Add GitLab's version history note(s). -
Add/update the feature flag section.
Review checklist
All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Documentation Guidelines and Style Guide.
1. Primary Reviewer
-
Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.
2. Technical Writer
-
Technical writer review. If not requested for this MR, must be scheduled post-merge. To request for this MR, assign the writer listed for the applicable DevOps stage. -
Ensure docs metadata are present and up-to-date. -
Ensure Technical Writing and documentation are added. -
Add the corresponding docs::
scoped label. -
If working on UI text, add the corresponding UI Text
scoped label. -
Add twdoing when starting work on the MR. -
Add twfinished if Technical Writing team work on the MR is complete but it remains open.
-
For more information about labels, see Technical Writing workflows - Labels.
For suggestions that you are confident don't need to be reviewed, change them locally and push a commit directly to save others from unneeded reviews. For example:
- Clear typos, like
this is a typpo
. - Minor issues, like single quotes instead of double quotes, Oxford commas, and periods.
For more information, see our documentation on Merging a merge request.
3. Maintainer
-
Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review. -
Ensure a release milestone is set. -
If there has not been a technical writer review, create an issue for one using the Doc Review template.
Merge request reports
Activity
changed milestone to %14.0
added Technical Writing docs-linting documentation tw-testing twdoing labels
assigned to @eread
mentioned in issue #331002 (closed)
@marcel.amirault I think we're ready for this, I'm pretty sure with the recent docs release we have freshly deployed images, but we could deploy again just in case.
If you're content, could you forward to Engineering Productivity ?
Thanks!
requested review from @marcel.amirault
removed documentation label
- Resolved by Rémy Coutable
@eread Yup, LGTM!
- A deleted user
added Engineering Productivity label
Pipeline Changes
This merge request contains changes to the pipeline configuration for the GitLab project.
Please consider the effect of the changes in this merge request on the following:
- Effects on different pipeline types
- Effects on non-canonical projects:
gitlab-foss
security
dev
- personal forks
- Effects on pipeline performance
Please consider communicating these changes to the broader team following the communication guideline for pipeline changes
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer Engineering Productivity for CI, Danger Rémy Coutable ( @rymai
) (UTC+2, 8 hours behind@eread
)Rémy Coutable ( @rymai
) (UTC+2, 8 hours behind@eread
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded maintenancepipelines tooling (archive) labels and removed Engineering Productivity label
requested review from @rymai and removed review request for @marcel.amirault
added 7 commits
-
e539ab9a...e49d7bf4 - 6 commits from branch
master
- 8f6f0062 - Remove retry of docs job
-
e539ab9a...e49d7bf4 - 6 commits from branch
- A deleted user
added Engineering Productivity label
added 10 commits
-
8f6f0062...a416dad9 - 9 commits from branch
master
- 4baabed5 - Remove retry of docs job
-
8f6f0062...a416dad9 - 9 commits from branch
enabled an automatic merge when the pipeline for 7ea7f77b succeeds
- Resolved by Rémy Coutable
Failure is caused by #331910 (closed). Waiting for the revert to be merged first.
mentioned in commit 016b001a
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added typemaintenance label and removed tooling (archive) label