Geo - Alter the steps for creating an external tracking database
What does this MR do?
- The current instructions imply that the user already has a database to use for their tracking database. Borrowing the instructions from steps 1-2 in https://docs.gitlab.com/ee/administration/postgresql/external.html, let's make this more explicit here so there is no confusion.
- I've added
If you are **not** using a cloud managed PostgreSQL database
to step 3 - this currently leads to confusion for the reader if this does not apply to them. Not sure if a note would be more appropriate here - let me know. - Fixed spelling mistake in one of the links.
- When reconfiguring the secondary node after entering in the tracking database details, GitLab will automatically migrate the tracking database. This makes me wonder if the
gitlab-rake geo:db:create
andgitlab-rake geo:db:migrate
commands are actually worth mentioning. I feel thegitlab-rake geo:db:migrate
comes in handy if you ever need to run it manually (and no harm in running it again after the reconfigure), but unsure about thegitlab-rake geo:db:create
command - this could generate an error if the database already exists or the database user is not a superuser. cc @fzimmer - could you give some direction here or help me find someone who can?
Related issues
Author's checklist (required)
-
Follow the Documentation Guidelines and Style Guide. - If you have Developer permissions or higher:
-
Ensure that the product tier badge is added to doc's h1
. -
Apply the documentation label, plus: - The corresponding DevOps stage and group labels, if applicable.
-
development guidelines when changing docs under
doc/development/*
,CONTRIBUTING.md
, orREADME.md
. -
development guidelines and Documentation guidelines when changing docs under
development/documentation/*
. - development guidelines and Description templates (.gitlab/*) when creating/updating issue and MR description templates.
-
Request a review from the designated Technical Writer.
-
Do not add the feature, frontend, backend, ~"bug", or database labels if you are only updating documentation. These labels will cause the MR to be added to code verification QA issues.
When applicable:
-
Update the permissions table. -
Link docs to and from the higher-level index page, plus other related docs where helpful. -
Add the product tier badge accordingly. -
Add GitLab's version history note(s). -
Add/update the feature flag section.
Review checklist
All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Documentation Guidelines and Style Guide.
1. Primary Reviewer
-
Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.
2. Technical Writer
-
Technical writer review. If not requested for this MR, must be scheduled post-merge. To request for this MR, assign the writer listed for the applicable DevOps stage. -
Ensure docs metadata are present and up-to-date. -
Ensure Technical Writing and documentation are added. -
Add the corresponding docs::
scoped label. -
If working on UI text, add the corresponding UI Text
scoped label. -
Add twdoing when starting work on the MR. -
Add twfinished if Technical Writing team work on the MR is complete but it remains open.
-
For more information about labels, see Technical Writing workflows - Labels.
For suggestions that you are confident don't need to be reviewed, change them locally and push a commit directly to save others from unneeded reviews. For example:
- Clear typos, like
this is a typpo
. - Minor issues, like single quotes instead of double quotes, Oxford commas, and periods.
For more information, see our documentation on Merging a merge request.
3. Maintainer
-
Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review. -
Ensure a release milestone is set. -
If there has not been a technical writer review, create an issue for one using the Doc Review template.
Edited by Anton Smith