Skip to content

Add invite option to reviewer dropdown [RUN AS-IF-FOSS]

Doug Stull requested to merge 323757-add-invite-option-to-reviewer-dropdown into master

What does this MR do?

  • Add Invite Members to reviewer dropdown on Merge Requests.
  • Move tracking for dropdown into FOSS as there was no need to have it in ee as all code referencing it is in FOSS.
  • Refactored the common dropdown parts into a new partial to be shared between assignee and reviewer

How to test locally(GDK)

  • Go to an MR where you have owner/maintainer access and click on Edit on reviewers.

Screenshots (strongly suggested)

before/not-authorized after
Screen_Shot_2021-05-25_at_5.13.52_PM Screen_Shot_2021-05-25_at_5.11.40_PM
n/a Screen_Shot_2021-05-25_at_5.12.50_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #323757

Edited by Doug Stull

Merge request reports