Fix timeouts when destroying a project with many notes
What does this MR do?
Generally, we like to use foreign key associations to destroy dependent records. Where this is possible, it's faster and uses fewer resources than doing it in GitLab.
In 028db84c , the notes association was converted from dependent: :destroy to using foreign keys. However, when destroying a specific project with > 60K notes, we're experiencing statement timeouts in the staging environment. Additionally, notes have a deprecated attachments uploader that requires Ruby intervention to avoid orphaning files on disk - there are at least some notes on GitLab.com that still use this deprecated uploader.
Since 2017, we've introduced the BatchDestroyDependentAssociations concern, which takes care of processing large numbers of dependent records in batches. Re-introducing dependent: :destroy on notes will automatically make use of this code.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Related to #207222 (closed)