Redesign policy editor page
What does this MR do?
Redesign policy editor page
- wrap all pieces that are related to rule mode into rule mode section
How to test
https://gitlab.com/-/snippets/2070592
Screenshots (strongly suggested)
Notes on design vs implementation
- I did not modify any existing components (like make the
New rule
component or the new policy preview component) in this MR because I knew it was going to be kind of big, but that is coming - In the designs the
Policy Name
textbox and thePolicy Enabled
toggle are not inside the mode table, but both of these inputs affect the yaml and should be hidden when in yaml mode, so I pulled them into the table per the conversation here.
Page | Designs | Before | After |
---|---|---|---|
Policy Editor - Rule mode policy | #323771[new-policy-rule-mode-network.png] | ![]() |
![]() |
Policy Editor - Yaml mode policy | #323771[new-policy-yaml-mode-network.png] | ![]() |
![]() |
Policy Editor - Rule mode unparseable policy | - | ![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #323771 (closed)
Edited by Alexander Turinske