Skip to content

Redesign policy editor page

Alexander Turinske requested to merge 323771-redesign-policy-editor into master

What does this MR do?

Redesign policy editor page

  • wrap all pieces that are related to rule mode into rule mode section

How to test

https://gitlab.com/-/snippets/2070592

Screenshots (strongly suggested)

Notes on design vs implementation

  • I did not modify any existing components (like make the New rule component or the new policy preview component) in this MR because I knew it was going to be kind of big, but that is coming
  • In the designs the Policy Name textbox and the Policy Enabled toggle are not inside the mode table, but both of these inputs affect the yaml and should be hidden when in yaml mode, so I pulled them into the table per the conversation here.
Page Designs Before After
Policy Editor - Rule mode policy #323771[new-policy-rule-mode-network.png] image image
Policy Editor - Yaml mode policy #323771[new-policy-yaml-mode-network.png] yaml_-_b image
Policy Editor - Rule mode unparseable policy - unparseable_rule_-_b image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #323771 (closed)

Edited by Alexander Turinske

Merge request reports