Skip to content

Fix invite members button showing when signed out

Jackie Fraser requested to merge fix-other-modal-button-when-not-signed-in into master

What does this MR do?

Removes "Invite members" modal button from displaying on the Members page of public projects

Does not include a changelog entry because this is still behind the :invite_members_group_modal feature flag

Related to feature flag rollout issue: https://gitlab.com/gitlab-org/gitlab/-/issues/247208

To reproduce

  1. Feature.enable(:invite_members_group_modal)
  2. Create a public project while signed in as admin
  3. Sign out
  4. Visit the Members page of the public project

Screenshots (strongly suggested)

before after
before2 after

Note: The "Invite a group" button is displaying for a different reason, not only for public projects, and is fixed in a separate MR

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports