Skip to content

Hide code quality annotation space when feature flag is disabled

Miranda Fluharty requested to merge 2526-hide-space-when-flag-disabled into master

What does this MR do?

In !57926 (merged) we introduced inline code quality annotations behind the feature flag :codquality_mr_diff_annotations, but did not check for the feature flag before adding the space that the icons will appear in 😅 so files with new code quality degradations are inexplicably indented 20px more than files without them:

image

from a thread in #is-this-known (internal link)

This MR checks for the feature flag :codquality_mr_diff_annotations before we add the with-codequality class to the diff grid, so that the column for the code quality annotations is only expanded from 0 to 20px when the feature flag is enabled.

Screenshots (strongly suggested)

what happens now what should happen with this MR
Screen_Shot_2021-05-21_at_10.21.18 the second file is indented more for no reason Screen_Shot_2021-05-21_at_10.18.56 indentation is the same across all files

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Related to #2526 (closed)

Edited by Miranda Fluharty

Merge request reports