Skip to content

Geo Node 2.0 - Remove geo_nodes_beta FF [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Zack Cuddy requested to merge 296986-remove-geo_nodes_beta-FF into master

Prelude

The Geo Node 2.0 view is finally coming to a close! Over the past few months we have been implementing an entire new view for Geo behind the :geo_nodes_beta feature flag. This was a from the ground up rewrite of the UI. The legacy UI used things like the event_bus and api_service files to manage the UI. The new UI implements a Vuex store as well as utilizes the api.js file to manage data calls!

Along with the above data management changes this change also introduced a much more Pajama's friendly UI though usage of GitLab UI. The entire path of this change can be read up on more in the Epic: &4712 (closed)

What does this MR do?

Closes #296986 (closed)

This MR fully removes the :geo_nodes_beta feature flag and the entire legacy code scope. This code is no longer needed and the UI now uses the ee/geo_nodes_beta scope. Which following this MR will then all be renamed to geo_nodes 😇

There is a lot of code being removed here but fear not we have been vigorously regression testing the new UI in staging and we have a high level of confidence that this is ready to be removed 🔥

Screenshots (strongly suggested)

Old UI New UI
Screen_Shot_2021-05-21_at_10.39.18_AM Screen_Shot_2021-05-21_at_10.38.48_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #296986 (closed)

Edited by Zack Cuddy

Merge request reports