Skip to content

Prepare taggings table for bigint conversion

Heinrich Lee Yu requested to merge 329536-taggings-bigint into master

What does this MR do?

Prepares migration of taggings table to bigint.

Related to #329536 (closed)

Migration output

Up

== 20210520133032 InitializeConversionOfTaggingsToBigint: migrating ===========
-- table_exists?(:taggings)
   -> 0.0019s
-- column_exists?(:taggings, :id)
   -> 0.0030s
-- column_exists?(:taggings, :id)
   -> 0.0011s
-- column_exists?(:taggings, :taggable_id)
   -> 0.0011s
-- columns(:taggings)
   -> 0.0013s
-- add_column(:taggings, "id_convert_to_bigint", :bigint, {:default=>0, :null=>false})
   -> 0.0148s
-- columns(:taggings)
   -> 0.0012s
-- add_column(:taggings, "taggable_id_convert_to_bigint", :bigint, {:default=>nil})
   -> 0.0012s
== 20210520133032 InitializeConversionOfTaggingsToBigint: migrated (0.0942s) ==

== 20210520133440 BackfillTaggingsForBigintConversion: migrating ==============
-- table_exists?(:taggings)
   -> 0.0014s
-- column_exists?(:taggings, :id)
   -> 0.0021s
-- column_exists?(:taggings, :id)
   -> 0.0011s
-- column_exists?(:taggings, "id_convert_to_bigint")
   -> 0.0010s
-- column_exists?(:taggings, :taggable_id)
   -> 0.0012s
-- column_exists?(:taggings, "taggable_id_convert_to_bigint")
   -> 0.0010s
unknown OID 28: failed to recognize type of 'relfrozenxid'. It will be treated as String.
unknown OID 1034: failed to recognize type of 'relacl'. It will be treated as String.
unknown OID 194: failed to recognize type of 'relpartbound'. It will be treated as String.
== 20210520133440 BackfillTaggingsForBigintConversion: migrated (0.0694s) =====

Down

== 20210520133440 BackfillTaggingsForBigintConversion: reverting ==============
-- execute("DELETE FROM batched_background_migrations WHERE job_class_name = 'CopyColumnUsingBackgroundMigrationJob' AND table_name = 'taggings' AND column_name = 'id' AND job_arguments = '[[\"id\",\"taggable_id\"],[\"id_convert_to_bigint\",\"taggable_id_convert_to_bigint\"]]'")
   -> 0.0048s
== 20210520133440 BackfillTaggingsForBigintConversion: reverted (0.0051s) =====

== 20210520133032 InitializeConversionOfTaggingsToBigint: reverting ===========
-- remove_column(:taggings, "id_convert_to_bigint")
   -> 0.0013s
-- remove_column(:taggings, "taggable_id_convert_to_bigint")
   -> 0.0008s
== 20210520133032 InitializeConversionOfTaggingsToBigint: reverted (0.0059s) ==

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mayra Cabrera

Merge request reports