Skip to content

Expose the state field for findings

Savas Vedova requested to merge 331409-add-status-column into master

What does this MR do?

Recently, with !61536 (merged) we started using the vulnerability_list.vue component in the Pipeline Security Dashboard. This list is backed by GraphQL and was already used in the Project, Group and Instance. This MR fetches the state field from the backend and displays it in the vulnerability list in the pipeline security dashboard.

Desc link
Prepare the components for the migration !61132 (merged) & !61136 (merged)
Mount vulnerability list on pipeline dashboard !61536 (merged) (I believe this was the biggest chunk)
Make filters work with the pipeline To come
Implement sorting functionality To come
Add statuses to findings 👈🏻 We're here
Add modal to show additional information on findings To come
Bulk status update for findings To come

Steps to test:

  1. Fork a repository (such as https://gitlab.com/gitlab-examples/security/security-reports/)
  2. Run the pipeline
  3. Enable the feature flag: :pipeline_security_dashboard_graphql
  4. Go to Project > CI/CD > Pipelines > Your Pipeline > Security Tab

Screenshots (strongly suggested)

before after
Screenshot_2021-05-19_at_15.07.50 image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #331409 (closed)

Edited by Max Woolf

Merge request reports