Expose the state field for findings
What does this MR do?
Recently, with !61536 (merged) we started using the vulnerability_list.vue
component in the Pipeline Security Dashboard
. This list is backed by GraphQL and was already used in the Project
, Group
and Instance
. This MR fetches the state field from the backend and displays it in the vulnerability list in the pipeline security dashboard.
Desc | link |
---|---|
Prepare the components for the migration | !61132 (merged) & !61136 (merged) |
Mount vulnerability list on pipeline dashboard | !61536 (merged) (I believe this was the biggest chunk) |
Make filters work with the pipeline | To come |
Implement sorting functionality | To come |
Add statuses to findings |
|
Add modal to show additional information on findings | To come |
Bulk status update for findings | To come |
Steps to test:
- Fork a repository (such as https://gitlab.com/gitlab-examples/security/security-reports/)
- Run the pipeline
- Enable the feature flag:
:pipeline_security_dashboard_graphql
- Go to Project > CI/CD > Pipelines > Your Pipeline > Security Tab
Screenshots (strongly suggested)
before | after |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #331409 (closed)
Edited by Max Woolf