Skip to content

UX improvements for inline code quality [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Miranda Fluharty requested to merge 2526-inline-codequality-ux-improvements into master

What does this MR do?

This MR handles UX feedback for the inline code quality icons/annotations feature (#2526 (closed)) introduced by !57926 (merged). This MR adds a white border to the inline code quality icons to allow for proper contrast with the background no matter which code theme they appear in, and this MR adds a modal to open when an inline code quality icon is clicked that displays the details of the new violations on that line.

Testing instructions:

  • This is a GitLab Ultimate feature, defined as inline_codequality in license.rb so you must have the appropriate license loaded to see the feature
  • This feature is behind the feature flag :codequality_mr_diff_annotations - echo "Feature.enable(:codequality_mr_diff_annotations)" | rails c to enable it
  • The default code quality template is designed for docker-in-docker, but I would recommend setting up a specific local runner using these instructions if you want to fully test this in your gdk

Screenshots

gutter icons in diff view tooltip on hover modal on click
Screen_Shot_2021-06-11_at_12.10.54 Screen_Shot_2021-06-11_at_12.11.30 Screen_Shot_2021-06-11_at_12.11.51

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Miranda Fluharty

Merge request reports

Loading