Skip to content

Check for credit card when playing manual jobs

Fabio Pitino requested to merge prevent-play-job-without-cc-info into master

What does this MR do?

Related to https://gitlab.com/gitlab-org/gitlab/-/issues/331090

In this MR we enforce the check on Credit Card data in order to run any manual jobs (builds or bridge jobs). It could happen that a user could run manual jobs from pipelines created while the credit card requirement didn't apply.

Screenshots (strongly suggested)

Pipeline created by disabling shared runners

image

Running manual job after enabling shared runners

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Fabio Pitino

Merge request reports

Loading