Add and fix various things in issues page refactor
What does this MR do?
This MR adds and fixes various things in issues page refactor (#322755 (closed)), behind the vue_issues_list
feature flag defaulted to off:
- Adds current user as first suggestion when AuthorToken is loading (to satisfy feature spec)
- Shows My-Reaction and Confidential tokens only when logged in
- Fixes empty state to correctly show when a filtered search has taken place (to satisfy feature spec)
- Fixes clicking on an issue card label not filtering correctly
- Improves mobile layout
- Also renames
hasIssues
tohasProjectIssues
and extract strings to constants
Screenshots (strongly suggested)
AuthorToken shows current user | Tokens when logged out | Tokens when logged in |
---|---|---|
![]() |
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #322755 (closed)
Edited by Coung Ngo