Skip to content

Add and fix various things in issues page refactor

What does this MR do?

This MR adds and fixes various things in issues page refactor (#322755 (closed)), behind the vue_issues_list feature flag defaulted to off:

  • Adds current user as first suggestion when AuthorToken is loading (to satisfy feature spec)
  • Shows My-Reaction and Confidential tokens only when logged in
  • Fixes empty state to correctly show when a filtered search has taken place (to satisfy feature spec)
  • Fixes clicking on an issue card label not filtering correctly
  • Improves mobile layout
  • Also renames hasIssues to hasProjectIssues and extract strings to constants

Screenshots (strongly suggested)

AuthorToken shows current user Tokens when logged out Tokens when logged in
Screenshot_2021-05-19_at_11.54.31_am Screenshot_2021-05-19_at_12.16.17_pm Screenshot_2021-05-19_at_11.54.53_am

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #322755 (closed)

Edited by Coung Ngo

Merge request reports