Skip to content

Move member creation process out of model [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Doug Stull requested to merge move-member-creator-to-own-class into master

What does this MR do?

  • Move adding users to a project or group out of the Member Model class.
    • Improves encapsulation of logic.
    • Reduces Model class bloat.

What does this MR NOT do?

  • Does not try to refactor existing methods that were moved too much. Doing that would be harder to review this change and some patterns may not be clear enough to do that at this point.
    • This means the code in the new classes can seem a bit ugly, and if so - we should follow-up

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Douglas Barbosa Alexandre

Merge request reports