Skip to content

Avoid N+1 queries while processing uploads

Michael Kozono requested to merge mk/fix-n-plus-1-queries-in-upload-file-check into master

What does this MR do?

Improves performance of upload file check rake task rake gitlab:uploads:check. Reduces load on the DB when running the task.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary Not needed since A fix for a regression introduced and then fixed in the same release should not have a changelog entry.
  • Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a Backend maintainer
    • Has been reviewed by a Database specialist
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • If you have multiple commits, please combine them into a few logically organized commits by squashing them
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

Resolves https://gitlab.com/gitlab-org/gitlab-ce/issues/47924

Edited by Michael Kozono

Merge request reports