Skip to content

Resolve "Incorrect system notes and email notifications when unassigning users via API"

What does this MR do?

This MR addresses issues with post-update actions not being applied, due to deduplication keys for the jobs not being cleared.

Manual QA steps

Unfortunately, due to subtle interactions with our Sidekiq middleware, the best way to test this is manually.

To do so, you should set up a GDK, and get yourself a personal access token. We also need to work with an MR. I am using flightjs/flight!1 in my examples below.

Steps:

url="http://localhost:3000/api/v4/projects/flightjs%2Fflight/merge_requests/1"
auth="Authorization: Bearer $TOKEN"
curl -X PUT -s -H "$auth" "$url" -d title="Updated at $(date)" | jq '{title, id}';
for i in 0 1 2 3 4 2 3 0 1 ; do
  curl -X PUT -s -H "$auth" "$url" -d assignee_id=$i | jq '{id, title, assignee: (.assignee.username)}'
  sleep 10
done

Observe as the system notes are added to the MR page, one by one.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Related to #331102 (closed)

Edited by Alex Kalderimis

Merge request reports