Remove size information from the message of ExceedLimitError
What does this MR do?
The size limiter was already deployed into production and track mode was enabled (gitlab-com/gl-infra/production#4451 (closed) and gitlab-com/gl-infra/production#4487 (closed)).
After enabling the flags, Sentry observed a series of incoming events as expected. However, they are not grouped into one error group. Sentry tends to group the events based on their worker classes and messages. Having a dynamic parameter in the message prevents Sentry from grouping the events, even though the events are for the same worker class.
This is an example of the event message: WebHookWorker job exceeds payload size limit (163810/100000). In the payload sent to Sentry, the current size and limit was included. Hence, the size information is redundant here.
This MR is to simply remove that part.
Screenshots (strongly suggested)
Before
After
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team


