Skip to content

GitLab Next

    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Menu
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 43,083
    • Issues 43,083
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,355
    • Merge requests 1,355
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge requests
  • !61850

Replace klar with container-scanning

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Thiago Figueiró requested to merge 331050-make-trivy-the-default-container-scanning-analyzer into master May 16, 2021
  • Overview 79
  • Commits 10
  • Pipelines 20
  • Changes 7

What does this MR do?

  1. Replaces klar with container-scanning as the default analyzer for container scanning.
  2. Simplifies the template (we will be supporting multiple scanner and variations very soon).
  3. Removes mentions to klar, clair, clair-db from CI templates and user documentation.
  4. Other clean-ups are being done as part of !62326 (merged).

This MR is related to this issue.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

  • I have included a changelog entry, or it's not needed. (Does this MR need a changelog?)
  • I have added/updated documentation, or it's not needed. (Is documentation required?)
  • I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
  • I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
  • I have self-reviewed this MR per code review guidelines.
  • This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines)
  • I have followed the style guides.

Availability and Testing

  • I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.)
  • I have tested this MR in all supported browsers, or it's not needed.
  • I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #331050 (closed)

Edited May 24, 2021 by Thiago Figueiró
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 331050-make-trivy-the-default-container-scanning-analyzer