Skip to content

Prune all the Geo event log tables correctly

Toon Claes requested to merge tc-geo-prune-events-correctly into master

What does this MR do?

The Geo::PruneEventLogWorker did prune the geo_event_log table, but rows from the associated (e.g. geo_repository_created_events table) were not pruned.

This MR fixes the Geo::PruneEventLogWorker and adds a post-deploy migration to remove all orphaned rows in the associated event tables.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a UX Designer
    • Has been reviewed by a Frontend maintainer
    • Has been reviewed by a Backend maintainer
    • Has been reviewed by a Database specialist
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • If you have multiple commits, please combine them into a few logically organized commits by squashing them
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

Closes gitlab-org/gitlab-ee#6422

gitlab-org/gitlab-ee#6621

Edited by Toon Claes

Merge request reports