Skip to content

Fix animation for pipeline editor drawer on load

Frédéric Caplette requested to merge 296547-fix-animation-on-load into master

What does this MR do?

When the page was loading, we had a transition all which resulted in the drawer being moved diagonally into position and it looked weird. Instead, we now only transition on width property. Also, we default the state of the drawer to close and we programatically set it to open if there is no value in the local storage. That way, we get a nice opening animation that wasn't there before.

Important This needs gitlab-ui version 29.25 or higher to work, so we need renovate to have bumped gitlab-ui before merge.

Screenshots (strongly suggested)

Before After
Screen_Recording_2021-05-13_at_7.57.01_AM Screen_Recording_2021-05-13_at_7.45.35_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #296547 (closed)

Edited by Frédéric Caplette

Merge request reports