Skip to content

Rate-limited action caching for branches API [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Robert May requested to merge grape-action-caching into master

What does this MR do?

Adds action-caching to the Grape API, allowing us to fully cache the response of an action.

This adds the action cache to the branches list API, which introduces a 30 second cache/delay to identical requests on the endpoint. This means that identical requests from the same user will return identical data for up to 30 seconds, drastically lowering pressure on Gitaly when under load. It does mean that new branches, for example, will take up to 30 seconds to appear on the API.

Related #330128 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Robert May

Merge request reports