Skip to content

Add `MembersTabs` Vue component

📖 What does this MR do?

Related to #324681 (closed)

This MR is an attempt to split up !61524 (merged) into smaller chunks to make it easier to review. Unfortunately this means we lose a bit of context as to how it integrates with the rest of the application.

We are in the process of converting the group/project member Bootstrap tabs to GlTabs. This MR introduces a MembersTabs component that will be used in future MRs to achieve this goal. The MembersTabs component is not yet used and therefore this MR does not introduce any visual/functionality changes.

When we switch to using this component we will render MembersTabs in app/assets/javascripts/members/index.js#L51 instead of rendering App.

💻 Local testing

This component is not yet used, you can checkout !61524 (merged) if you would like to test locally with everything wired up.

📷 Screenshots

No visual changes. For context, the screenshots below show what the new tabs will look like once #324681 (closed) is completed (they are supposed to look almost identical 🙂)

Before After
Screen_Shot_2021-05-13_at_8.10.23_AM Screen_Shot_2021-05-13_at_8.07.18_AM

🚦 Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports