Skip to content

Improve clarity in the Users::BuildService [RUN AS-IF-FOSS]

What does this MR do?

  • Step 1 from this plan.
  • !61734 (merged) updated the test spec first to ensure all possible coverage gaps were resolved.
  • Update structure and reduce per method complexity.
    • !61520 (merged) has the larger picture.
    • this class still has a LOT going on and could be further refactored along the lines of admin or not perhaps...but at this point, it isn't clear if that would help or not.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #328806

Edited by Doug Stull

Merge request reports