Cache the commit partials in MRs [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
Caches the commit partial renders in the commits tab on MRs and in the /commits path. This scopes the current pipeline status into the cache key, meaning that old commits with finished pipelines will usually be served from the cache and save significant rendering time.
The amount of time saved is hard to calculate locally, but I would expect at least a 25% improvement in the rendering speed of the commits action. Optimistically something like 75% wouldn't be impossible. Locally an example MR without pipelines drops from 140ms to 90ms.
Related #209912
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team