Skip to content

Move runner pagination support to controllers

What does this MR do?

This MR moves runner pagination support from Ci::RunnersFinder to controllers. Having mandatory pagination does not make sense if we reuse this class.

There's even a consumer of RunnersFinder which is calling paging code itself after the same setup in Ci::RunnersFinder#paginate.

for GraphQL queries.

Screenshots (strongly suggested)

With NUMBER_OF_RUNNERS_PER_PAGE = 1:

Screen_Shot_2021-05-12_at_11.22.49_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Part of #328518 (closed)

Edited by Allison Browne

Merge request reports