Skip to content

Fix members autocomplete showing non-matches

Coung Ngo requested to merge 330511-fix-autocomplete-showing-non-matches into master

What does this MR do?

This MR fixes members autocomplete showing non-matches.

Currently, member autocomplete using @ incorrectly shows non-matches. If you type @marge., you are still shown the complete list of members even though there are no matches. The expected behaviour is that the autocomplete list only shows matches.

Issue: #330511 (closed)

Screenshots (strongly suggested)

before after
Screenshot_2021-05-12_at_11.50.34_am Screenshot_2021-05-12_at_11.41.27_am
Screenshot_2021-05-12_at_11.50.43_am Screenshot_2021-05-12_at_11.41.35_am

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #330511 (closed)

Edited by Coung Ngo

Merge request reports