Skip to content

Document locking of markdown cache version

John Hope requested to merge jh-document-and-lock-markdown-cache into master

What does this MR do?

See #330313 (closed)

Incremening the markdown cache version requires all rows with cached markdown to be update, putting strain on the database. This has resulted in at least one production incident (See gitlab-com/gl-infra/production#4481 (closed)).

The corrective action is to lock this file, along with a description on why the file was locked. This MR includes the description and the maintainer should lock the file using the UI once it's merged.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading