Skip to content

Delay workers that are utilizing load balancing capabilities [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Nikola Milojevic requested to merge add-data-consistency-delay into master

The Problem

When we call perform_async, the job will be pushed to the queue immediately. In some cases, this means that the job will be executed in a really short time (0.003s).

For some jobs we want to utilize LoadBalancing(use replica), by specifying data_consistency to :delayed or :sticky, we are comparing WAL (Write ahead log) location against replica to determine that replica has caught up with the primary.

If a replica is not up to date, we will retry the job or we will stick to the primary.

If the job is executed in 0.003s there is really little chance that the replication process has finished, and that replica will be up to date, so it's more likely that we will retry the job, or fall back to the primary...

This can result in lot of job retries, so we will try to delay execution for 1s for these jobs to give the replication process time to complete.

What does this MR do?

It extracts logic introduced in #330136 (closed):

Workers can utilize Sidekiq read-only database replicas capabilities by setting the data_consistency attribute. Workers with data_consistency set to :delayed or :sticky, calling #perform_async should be delayed in order to give the replication process enough time to complete.

This MR will delay the execution of peroform_async method for jobs that have data_consistency != :always. The execution will be delayed by default for 1s.

This is set behind the :data_consistency_delayed_execution feature flag

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes: #330639 (closed)

Edited by Nick Thomas

Merge request reports