Remove the redundant update for API endpoint projects/:id/statuses/:sha
What does this MR do?
In issue #326791 (closed), we are trying to remove all usages of Ci::ProcessPipelineService#update_retried, but there are still some usages for some pipelines.
When I look at those pipelines, I realized that all of them are triggered via the API endpoint projects/:id/statuses/:sha. Then looked at deeply...
We have an update method in this endpoint, before all processes. This update method aims to assign some optional parameters. However, that update also triggers the after_transition callback of CommitStatus, and this enqueues PipelineProcessWorker.
Why can we just replace "update" with "assign_attributes"?
If those assignments are valid, then they will be saved eventually in enqueue,run,success,drop,cancel events. So, we don't need to update there.
Screenshots (strongly suggested)
Investigation process:
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team