Skip to content

Show only open items with "in progress" VSA

Adam Hegyi requested to merge 329620-exclude-closed-items-vsa into master

What does this MR do?

This change alters the in_progress filter in Value Stream Analytics. When the in progress filter is given, the backend will only query the Issue and Merge Request records which are in opened state.

The change is not user facing, the filter is not used on the UI yet.

Database

See the query tab in the depesz link for the full query.

The difference between the old and new query is the extra state_id" IN (1) filter. The timings are cached timings. Uncached timings are <2s on PRD, the performance is slightly better with the new queries.

Issue query

The new query reduces the number of rows a bit and uses an index that covers the state_id column.

MR query

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #329620 (closed)

Edited by Adam Hegyi

Merge request reports