Skip to content

Resolve "Extract EE specific files/lines for spec/spec_helper.rb"

Lin Jen-Shin requested to merge 6420-unify-spec_helper.rb into master

What does this MR do?

Resolve "Extract EE specific files/lines for spec/spec_helper.rb"

Are there points in the code the reviewer needs to double check?

One specific line left:

require_relative '../ee/spec/spec_helper'

We could see how else we want to do this, but I don't feel we could make CE/EE identical unless we're up to some magic.

This is a similar situation with prepend. I am wondering if we might want some black magic at some point to make them really exactly identical? Even if we do, apparently not now though.

Does this MR meet the acceptance criteria?

  • Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a Backend maintainer
  • EE specific content should be in the top level /ee folder

What are the relevant issue numbers?

Closes #6420 (closed)

Merge request reports