Geo 2.0 Regression - Timezone Issues
What does this MR do?
Fixes #329817 (closed)
This bug was found on staging as the server and my client had different timezones. We are using the timeago component to display when the last event occurred. The way we were passing the data caused the component to not track the TZ information and thus when it displayed the time ago it would include any TZ difference, which wasn't accurate.
The root issue was that we store Number timestamps in the server. The timeago component only accepted Strings and the helper methods didn't recognize Number timestamps in String form as valid Dates. Thus we tried converting the timestamp to a Date String. The Date String of course didn't include the TZ data
To fix this simply adding Number support to the timeago component worked. This ensures that Number timestamps can be passed to the helper methods.
It is going to be hard to show a true screenshot of this working as this issue will not happen on the GDK as the client and server will always match TZs.
This change is also behind a feature flag (:geo_nodes:beta)
How to test
- Set up a Geo Primary/Secondary GDK
- Fetch the current branch
- Activate the Feature Flag on your Primary GDK (
:geo_nodes_beta) - Navigate to
http://127.0.0.1:3000/admin/geo/nodes_beta - View UI
Screenshots (strongly suggested)
| Bug | Fix (everything works) |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because change is behind a FF.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #329817 (closed)