Skip to content

Fix sort params in issues page refactor

What does this MR do?

This MR fixes the sort parameters in the issues page refactor (#322755 (closed)), which is behind the vue_issues_list feature flag defaulted to off.

On the existing Haml page, the page reloads when a new sort option is chosen. In the Vue refactor, when a new sort option is chosen the list is updated via AJAX and the URL parameters are programmatically updated so that the page can be bookmarked like before.

In the Vue refactor, the URL parameters were updated to order_by=created_at&sort=desc when sorting but in production it's actually sort=created_date. This was identified when running the feature specs with the vue_issues_list feature flag on. Also, the Priority, Label priority, Manual, and Blocking sort options only have one sort order on production, so these discrepancies were updated in the Vue refactor.

Changes to feature tests were made so that when the feature flag is removed, the specs for sorting will still pass.

Screenshots (strongly suggested)

No visual changes

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #322755 (closed)

Edited by Coung Ngo

Merge request reports