Skip to content

Verify phone number format in trial form

What does this MR do?

Verify phone number format in trial form

  • The phone data isn't stored in gitlab, but sent to CustomersDot and Salesforce via an API call
  • This first iteration HTML5 input validation on the frontend of gitlab to give better formatted phone numbers

Related to #326452 (closed)

Validity

Validity
+1 202 555 0156 Valid
202 555 01 56 Valid
202 555-01-56 Valid
(202) 555 01 56 Invalid - Parenthesis are disallowed
(202) aaA=1` Any letters or non-allowed characters invalid

Screenshots

First form Second form
screenshot-2021-05-10-15-41-40 screenshot-2021-05-10-15-42-44

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alper Akgun

Merge request reports