Use consistent cache naming for set caches
What does this MR do?
Issue: #331319 (closed)
Cache key naming
This changes the RepositorySetCache cache key naming scheme to add the cache:gitlab namespace to the front of the cache key.
This is in line with how other caches work & aims to keep our cache naming consistent and predictable, which make them easier to work with (such as clearing caches).
Redis instances used by GitLab could in theory be used by other applications & so adding a cache:gitlab prefix to all caches make it clear what the cache is for.
| Old key | New key |
|---|---|
branch_names:root/autodevops-deploy-test:21:set |
cache:gitlab:branch_names:root/autodevops-deploy-test:21:set |
Improved usage of rake task
As a result of the naming change, the cache:clear:redis rake task is now more useful and will delete the RepositorySetCache entries which were previously unable to be deleted easily.
I've added a couple of tests to ensure test the caches expected to be cleared by the rake task.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team