Skip to content

Geo 2.0 Regression - Broken Popovers

Zack Cuddy requested to merge 329827-geo-beta-fix-popovers into master

What does this MR do?

Fixes #329827 (closed)

There were two bugs to be addressed here

  1. By default the Progress Bars set the popover target by the title. There was a mistake and the verification and sync sections were using the same name causing the target to get confused. Correcting the popover title fixes this.

  2. Since we hide/show the mobile/desktop views based on media breakpoints. The mobile and desktop components use the same naming convention. This causes the popovers to not work on mobile since it is targeting the hidden desktop version due to it being higher in the DOM tree. Adding a target prop to the popover component to be explicit about the popovers fixes this.

This change is also behind a feature flag (:geo_nodes:beta)

How to test

  1. Set up a Geo Primary/Secondary GDK
  2. Fetch the current branch
  3. Activate the Feature Flag on your Primary GDK (:geo_nodes_beta)
  4. Navigate to http://127.0.0.1:3000/admin/geo/nodes_beta
  5. View UI

Screenshots (strongly suggested)

Bug Fix
Wrong Popover Screen_Shot_2021-05-07_at_11.13.49_AM Screen_Shot_2021-05-07_at_11.13.05_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #329827 (closed)

Edited by Zack Cuddy

Merge request reports