Skip to content

Remove artifacts from pipeline details entity

Max Orefice requested to merge mo-remove-artifacts-from-pipeline-entity into master

Ref: #329798 (closed)

What does this MR do?

This MR removes our artifacts attribute from PipelineDetailsEntity API.

Why are we doing this?

Following up the work in #324003 (closed) where we started to lazy load downloadable artifacts once a user click on it as you can see below 👇

We continue to improve the ~performance of the index pipeline page, by cleaning up unnecessary data exposed by our API:

  1. First step was to get rid of has_downloadable_artifacts which is no longer used by the frontend. This was done in !60950 (merged)
  2. Next step is to remove those artifacts from being loaded on the pipeline page to improve page loading. !61253 (merged)

Screenshots (strongly suggested)

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Max Orefice

Merge request reports